Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: PR Template in CONTRIBUTING.md is corrected #241

Closed
wants to merge 2 commits into from
Closed

docs: PR Template in CONTRIBUTING.md is corrected #241

wants to merge 2 commits into from

Conversation

shruti1421
Copy link

Description

Now, if we click "this template" in CONTRIBUTING.md file PR template page opens successfully.

Fixes #230

Type of Change:

Delete irrelevant options.

  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

If you are working on a design then add a gif to show the responsiveness of your design.
Please follow testing guidelines and share the link of deployed site here.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have made corresponding changes to the documentation

Code/Quality Assurance Only

  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes

Rahulm2310
Rahulm2310 approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@Rahulm2310 Rahulm2310 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shruti1421 Although, the changes looks fine, still why the link is not working from your branch on your forked repo.
this-template

@shruti1421
Copy link
Author

@Rahulm2310 Now, you can check I've added the correct link in docs/CONTRIBUTING.md file too.

jhalak27
jhalak27 approved these changes Feb 26, 2021
View reviewed changes
Copy link

@jhalak27 jhalak27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@Rahulm2310
Copy link
Contributor

Working!. @shruti1421 just a suggestion. Both of your commits have the same commit message. Please be more specific regarding the commit messages like what this commit is fixing or changing. For now, thanks for your contribution 🎉

@keshakaneria keshakaneria added the Status: Needs Review PR needs an additional review or a maintainer's review. label Mar 3, 2021
@Rahulm2310
Copy link
Contributor

@keshakaneria As this PR already has 2 reviews, it is ready to merge.

@keshakaneria
Copy link
Member

@keshakaneria As this PR already has 2 reviews, it is ready to merge.

We followed this in OSH program last time if it has 2 reviews, then for final check by the maintainers to merge them so I added the same. Correct me if I'm wrong😄

@keshakaneria
Copy link
Member

Apologies for the labels @Rahulm2310, I cleared about this with OS Leaders, thus changing the labels accordingly 🚀

@keshakaneria keshakaneria added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Mar 8, 2021
@annabauza
Copy link
Contributor

@shruti1421 can you resolve conflicts please

@isabelcosta isabelcosta added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels May 24, 2021
@isabelcosta
Copy link
Member

I will close this PR due to lack of activity. Thank you @shruti1421 for contributing 🤗

@isabelcosta isabelcosta closed this Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhalak27 jhalak27 jhalak27 approved these changes

@Rahulm2310 Rahulm2310 Rahulm2310 approved these changes

Assignees
No one assigned
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR Template in CONTRIBUTING.md doesn't exist
6 participants
@shruti1421 @Rahulm2310 @keshakaneria @annabauza @isabelcosta @jhalak27