This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
label
Sep 5, 2017
This is a temporary PR while waiting for #10826 to re-open |
you can't inject $document into a Provider it's private and only used in theming to set browser color. Updated $mdThemingProvider.enableBrowserColor() to queue up color changes and dispatch them in the actual service.
relay on per application state.
Angular code should not use global state, it should be managed by providers. expose isDisabled() etc on $mdTheming remove theme disabling logic from md-themes-disabled directive (it has no effect after generateAllThemes is run, because that's the only location that reads themeConfig.disableTheming) check $document for md-themes-disabled in generateAllThemes.
58 failing tests
graingert
force-pushed
the
no-browser-globals-2
branch
from
September 25, 2017 23:34
7d1e6a3
to
b1f74c6
Compare
closing in favor of #10826 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use injectable $window and $document instead.
document
before it was available. Meta headers can only be changed via the $$mdMeta service.define a preset that sets
attachTo: angular.element($document[0].body)
inside a config function.$mdDialog.show($mdDialog.alert()...);
callsThis depends on eslint to find the misuse of global variables: #10824
What are $window and $document?
According to the AngularJS documentation: https://docs.angularjs.org/api/ng/service/$window
$document is similar
Why is this needed?