fix: unable to toggle icon in demo file #29354
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in demo file where icon cannot be toggled. This is because `signal` was not called correctly
abdulloh-abid
requested review from
crisbeto and
amysorto
and removed request for
a team
crisbeto
approved these changes
Jul 5, 2024
crisbeto
added
action: merge
crisbeto
pushed a commit
that referenced
this pull request
Jul 5, 2024
Fixes a bug in demo file where icon cannot be toggled. This is because `signal` was not called correctly (cherry picked from commit ccb9969)
crisbeto
pushed a commit
that referenced
this pull request
Jul 5, 2024
Fixes a bug in demo file where icon cannot be toggled. This is because `signal` was not called correctly (cherry picked from commit ccb9969)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes minor bug in demo file where icon cannot be toggled. This is because
signalwas not called correctly