fix(material/chips): remove button is too small #29351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
force-pushed
the
increase-chip-remove-touch-target-size
branch
from
049bd97
to
347ecef
Compare
angular-robot
bot
added
the
detected: breaking change
essjay05
force-pushed
the
increase-chip-remove-touch-target-size
branch
from
24e6edb
to
1319eee
Compare
essjay05
changed the title
essjay05
requested review from
crisbeto and
amysorto
and removed request for
a team
mmalerba
added
the
dev-app preview
mmalerba
reviewed
Jul 1, 2024
| @@ -398,6 +398,17 @@ | |||
| } | |||
| } | |||
|
|
|||
| //Increases mdc-dhip-remove trailing icon action touch-target in order to fix b/286959517 | |||
There was a problem hiding this comment.
nit: space after //
nit: "dhip" => "chip"
|
Deployed dev-app for 471bb9f to: https://ng-dev-previews-comp--pr-angular-components-29351-dev-4ylvjidv.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Fixes Angular Components Chip component where the touch target of the remove button of a chip is too small. Updates .mat-mdc-chip-remove to target more specific styles to override original style of padding: 8px so that the user has a larger touch target particularly on mobile devices. Fixes b/286959517
Fixes lint errors from previous commit for Angular Components Chip component where the remove button touch target is too small, particularly for touch/mobile devices. Increases padding on all sides. Fixes b/286959517
Fixes issue with Angular Component Chip's touch target size by increasing the padding on chips with a trailing icon that has an action. Fixes b/286959517 BREAKING CHANGE: updates chip remove button touch target to increase accessibility of the button especially on touch/mobile devices.
Updates fix to Autocomplete Component Chips component where the touch target size is too small and fails minimum accessibility size of 48x48 px. Addresses nit fixes from PR review. Fixes b/286959517 BREAKING CHANGE: updates padding size of remove touch target to satisfy minimum 48x48 accessibility size.
Fixes Angular Components Chip component where the touch target of the remove button of a chip is too small. Updates .mat-mdc-chip-remove to target more specific styles to override original style of padding: 8px so that the user has a larger touch target particularly on mobile devices. Fixes b/286959517
Fixes lint errors from previous commit for Angular Components Chip component where the remove button touch target is too small, particularly for touch/mobile devices. Increases padding on all sides. Fixes b/286959517
Fixes issue with Angular Component Chip's touch target size by increasing the padding on chips with a trailing icon that has an action. Fixes b/286959517 BREAKING CHANGE: updates chip remove button touch target to increase accessibility of the button especially on touch/mobile devices.
essjay05
force-pushed
the
increase-chip-remove-touch-target-size
branch
from
74eb432
to
471bb9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Angular Components Chip component where the touch target of the remove button of a chip is too small. Updates .mat-mdc-chip-remove to target more specific styles to override original style of padding: 8px so that the user has a larger touch target particularly on mobile devices.
Fixes b/286959517
Before screenshot
After screenshot
BREAKING CHANGE: updates chip remove button touch target to increase accessibility of the button especially on touch/mobile devices.