Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/select): Remove disableOptionCentering Input #29299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GiftLanga
Copy link
Contributor

Removes the disableOptionCentering field since the option centering functionality is no longer working in the mat-select component.

Fixes #28303

Removes the `disableOptionCentering` field since the option centering functionality is no longer working in the mat-select component.

Fixes angular#28303
@GiftLanga GiftLanga requested a review from a team as a code owner June 21, 2024 09:23
@GiftLanga GiftLanga requested review from crisbeto and andrewseguin and removed request for a team June 21, 2024 09:23
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be removed now, because it would be a breaking change. It needs to wait for the next major version.

@GiftLanga
Copy link
Contributor Author

This can't be removed now, because it would be a breaking change. It needs to wait for the next major version.

Should I keep the PR open?

@crisbeto
Copy link
Member

Up to you, but you should be aware that it won't be merged for a few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-bug(mat-select): Remove 'disabledOptionCentering' from API documentation
2 participants