Implement extend-theme functions for each component & overhaul override mixins to match behavior #29275
+3,588
−1,152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
approved these changes
Jun 18, 2024
mmalerba
changed the title
mmalerba
force-pushed
the
extend-theme
branch
3 times, most recently
from
b6e4fba
to
7ce26a8
Compare
mmalerba
added
the
merge: preserve commits
mmalerba
changed the title
mmalerba
added
target: major
mmalerba
force-pushed
the
extend-theme
branch
5 times, most recently
from
d450944
to
76e337a
Compare
mmalerba
requested review from
crisbeto and
amysorto
and removed request for
a team
mmalerba
force-pushed
the
extend-theme
branch
2 times, most recently
from
361cb9b
to
cc82e87
Compare
Initial commit, adds shared logic for appling overrides without validation of the given tokens.
Adds validation to the shared extend-theme logic along with tests to verify its behavior.
Adds the individual extend-theme functions for each component that delegate to the shared logic.
…nctions Adds a test to validate that the individual extend-theme functions do not have issues with unhandled overlapping short token names, and fixes issues that were uncovered.
…ions Avoids token name collisions between namespaces by assigning string prefixes to token in namespaces that would otherwise have a collision
…ponent>-extend-theme Adds the same handling of ambiugously named tokens for the <component>-overrides mixins that exists in the <component>-extend-theme functions. Also adds similar validation logic and tests to verify this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.