Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs-bug(mat-select): Remove 'disabledOptionCentering' from API documentation #28303

Open
eevardone opened this issue Dec 18, 2023 · 3 comments · May be fixed by #29299
Open

docs-bug(mat-select): Remove 'disabledOptionCentering' from API documentation #28303

eevardone opened this issue Dec 18, 2023 · 3 comments · May be fixed by #29299
Labels
area: material/select docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions

Comments

@eevardone
Copy link

eevardone commented Dec 18, 2023 •
edited
Loading

Documentation Feedback

Since Angular v15+ the, the option centering functionality is no longer working in the mat-select component. This was done to better align with the Material technical spec.

Please remove the 'disableOptionCentering' input from the API documentation.

Screenshot 2023-12-18 at 9 18 18 AM

Latest:
https://material.angular.io/components/select/api

v16:
https://v16.material.angular.io/components/select/api

v15:
https://v15.material.angular.io/components/select/api

Affected documentation page

https://material.angular.io/components/select/api
@eevardone eevardone added docs This issue is related to documentation needs triage This issue needs to be triaged by the team labels Dec 18, 2023
@crisbeto crisbeto mentioned this issue Dec 18, 2023
Closed
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions area: material/select and removed needs triage This issue needs to be triaged by the team labels Jan 8, 2024
@sanket-bhalerao
Copy link

is disableOptionCentering removed? 😮

@eevardone
Copy link
Author

eevardone commented Feb 22, 2024 •
edited
Loading

is disableOptionCentering removed? 😮

@sanket-bhalerao Last I checked, the ‘disableOptionCentering’ input is not removed but it certainly does not work as it is intended in the documentation since Angular 15+. This is due to the effort to better align with Material design.

@GiftLanga
Copy link
Contributor

I'm going to work on this issue, if no one is working on it.

GiftLanga added a commit to GiftLanga/angular-components that referenced this issue Jun 21, 2024
@GiftLanga
fix(material/select): Remove disableOptionCentering Inpu
38c0f6d 
Removes the `disableOptionCentering` field since the option centering functionality is no longer working in the mat-select component.

Fixes angular#28303
@GiftLanga GiftLanga linked a pull request Jun 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: material/select docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/select): Remove disableOptionCentering Input GiftLanga/angular-components
4 participants
@crisbeto @sanket-bhalerao @eevardone @GiftLanga