Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): clear context in Karma by default for single run executions #28315

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Aug 29, 2024

This works around #28271.

@dgp1130 dgp1130 added type: bug/fix target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker devkit/build-angular:karma labels Aug 29, 2024
@dgp1130 dgp1130 requested review from alan-agius4 and clydin August 29, 2024 18:09
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor NIT

@dgp1130 dgp1130 removed the request for review from clydin August 29, 2024 19:00
@dgp1130 dgp1130 merged commit 3ee2163 into angular:main Aug 29, 2024
30 checks passed
@dgp1130
Copy link
Collaborator Author

dgp1130 commented Aug 29, 2024

The changes were merged into the following branches: main, 18.2.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular-devkit/build-angular devkit/build-angular:karma target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants