Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

ui-select2 does not split on select2's "separator" option for multiple tags #156

Closed
wants to merge 1 commit into from

Conversation

GFoley83
Copy link

Bug related to PR 6d63149. Updated code to respect separator option instead of hard-coded comma. Splitting on a comma breaks if selected tag contains a comma e.g. selecting "Springsteen, Bruce" would cause two tags.

Bug related to PR angular-ui#115. Updated code to split on separator option instead of a comma. Splitting on a comma breaks if selected tag contains a comma e.g. selecting "Springsteen, Bruce" would cause two tags.
@qraynaud
Copy link

I included this & kept retro compatibility in PR #213. Maybe you could close this one and follow #213 ?

@themajix
Copy link

Hi Quentin,

I have entered #211 and #212. Which one you're referring to?

Thanks,
Majid

On Sun, May 18, 2014 at 1:42 PM, Quentin Raynaud
[email protected]:

I included this & kept retro compatibility in PR #213#213.
Maybe you could close this one and follow #213#213?


Reply to this email directly or view it on GitHubhttps://github.com//pull/156#issuecomment-43446153
.

@GFoley83
Copy link
Author

@qraynaud Reviewed #213 and looks good. Thanks 👍

@GFoley83 GFoley83 closed this May 18, 2014
@qraynaud
Copy link

@themajix: sorry, my message was for @GFoley83

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants