-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quiche path #221
Fix quiche path #221
Conversation
Since the quiche repository refactor in commit [#bbe6e2a](cloudflare/quiche@bbe6e2a) path for boringssl needs an update
I am not much confident in making github actions, but do you think you could make one for BoringSSL? |
While at it, there is a permanently disabled HTTP3 entry for an headless FULL installation in wrapper.sh which could get enabled as well. |
Does this PR remove the need for #220 ? |
You can enable it in this PR if you want, we could make sure that everything is fixed |
Yes it does |
On it |
I tried to recreate your [#f0f8714](angristan@f0f8714) just the opposite way.
Okay, so there is an error in checks which I do not get on my physical machine. |
Now I am even more confused as these checks were successful in my fork. |
I forgot to edit the nginx-1.16 patch path in the PR. The path is now fixed and checks are fixed as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Glad to help. |
Since the quiche repository refactor in commit #bbe6e2a path for boringssl needs an update. I tested this on my machine with success.