Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quiche path #221

Merged
merged 3 commits into from
Jan 29, 2022
Merged

Fix quiche path #221

merged 3 commits into from
Jan 29, 2022

Conversation

karelbasta
Copy link
Contributor

Since the quiche repository refactor in commit #bbe6e2a path for boringssl needs an update. I tested this on my machine with success.

Since the quiche repository refactor in commit [#bbe6e2a](cloudflare/quiche@bbe6e2a) path for boringssl needs an update
@karelbasta
Copy link
Contributor Author

I am not much confident in making github actions, but do you think you could make one for BoringSSL?

@karelbasta
Copy link
Contributor Author

While at it, there is a permanently disabled HTTP3 entry for an headless FULL installation in wrapper.sh which could get enabled as well.

@angristan
Copy link
Owner

Does this PR remove the need for #220 ?

@angristan
Copy link
Owner

While at it, there is a permanently disabled HTTP3 entry for an headless FULL installation in wrapper.sh which could get enabled as well.

You can enable it in this PR if you want, we could make sure that everything is fixed

@karelbasta
Copy link
Contributor Author

Does this PR remove the need for #220 ?

Yes it does

@karelbasta
Copy link
Contributor Author

While at it, there is a permanently disabled HTTP3 entry for an headless FULL installation in wrapper.sh which could get enabled as well.

You can enable it in this PR if you want, we could make sure that everything is fixed

On it

I tried to recreate your [#f0f8714](angristan@f0f8714) just the opposite way.
@karelbasta
Copy link
Contributor Author

Okay, so there is an error in checks which I do not get on my physical machine.
./configure: error: invalid option "--with-quiche=/usr/local/src/nginx/modules/quiche"
Which did not get changed in any of the commits.

@karelbasta
Copy link
Contributor Author

Now I am even more confused as these checks were successful in my fork.

@karelbasta
Copy link
Contributor Author

I forgot to edit the nginx-1.16 patch path in the PR. The path is now fixed and checks are fixed as well.

Copy link
Owner

@angristan angristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@angristan angristan merged commit 65076c2 into angristan:master Jan 29, 2022
@karelbasta
Copy link
Contributor Author

Glad to help.

@karelbasta karelbasta deleted the fix-quiche branch February 18, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants