-
Notifications
You must be signed in to change notification settings - Fork 112
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Apply badge color mask only for default color (#35)
* Reuse super state instead of instantiate a new one during the saving instance * Apply badge color mask only if there is no badge color defined * Remove lint warnings * Update screenshots for tests
- Loading branch information
Showing
3 changed files
with
7 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-11 Bytes
(100%)
...n.counterfab.sample.MainActivityTest_shouldKeepStateAfterOrientationChanged.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4 Bytes
(100%)
...on.counterfab.sample.MainActivityTest_shouldRenderSizeMiniWithCountProperly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8cee56b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!. cannot change colors in counter 'badgebackground'. No exist :(.
8cee56b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierogonzales, you mean this
app:badgeBackgroundColor
attribute?8cee56b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There is no attribute about the badge and its configuration.
8cee56b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you're missing something.. 🤔
Could you please add your code/layout snippet here to see what's wrong?