Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing unserialize integer overflow test #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

deeky666
Copy link

This is a weird bug I encountered. When having a script that contains an integer overflow, unserializing BloomFilter objects errors:

PHP 5

Notice: unserialize(): Error at offset 24 of 195 bytes

PHP 7

php: symbol lookup error: modules/bloomy.so: undefined symbol: smart_str_appendl

See attached test case.

Maybe this is related to #6

@deeky666
Copy link
Author

Okay boiled it down to this line. If I remove the errno == ERANGE check, everything works fine. As my PHP src knowledge is rather limited, I am not sure whether this is the correct solution. Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant