Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nested ordered identifiers are grouped (fixes #745) #746

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

john-bodley
Copy link
Contributor

Fixes #745.

Thanks for contributing!

Before submitting your pull request please have a look at the
following checklist:

  • ran the tests (pytest)
  • all style issues addressed (flake8)
  • your changes are covered by tests
  • your changes are documented, if needed

In addition, please take care to provide a proper description
on what your change does, fixes or achieves when submitting the
pull request.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f101546) 96.97% compared to head (d43fb9c) 96.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   96.97%   96.98%           
=======================================
  Files          20       20           
  Lines        1556     1557    +1     
=======================================
+ Hits         1509     1510    +1     
  Misses         47       47           
Files Coverage Δ
sqlparse/engine/grouping.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andialbrecht andialbrecht merged commit 39b5a02 into andialbrecht:master Mar 5, 2024
14 checks passed
@andialbrecht
Copy link
Owner

Ah, cool! Thanks for finding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The group_order() function fails to identify an ordered identifier in the context when nested
2 participants