Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute TokenList.value dynamically #623

Closed

Commits on May 11, 2021

  1. Perform token grouping within a filter.

    This will allow moving some filters to run before the tokens are
    grouped.
    living180 committed May 11, 2021
    Configuration menu
    Copy the full SHA
    f7c0e94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a748bde View commit details
    Browse the repository at this point in the history
  3. Merge methods.

    living180 committed May 11, 2021
    Configuration menu
    Copy the full SHA
    5537521 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Restructure token class hierarchy.

    Rename Token to TokenBase and make it a superclass for TokenList and a
    new Token class.  Move some of the functionality of TokenBase into Token
    and TokenList.
    living180 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    6a63356 View commit details
    Browse the repository at this point in the history
  2. Make TokenList.value a property not an attribute.

    The fact that a new value was being computed each time
    TokenList.group_tokens() is called caused supra-linear runtime when
    token grouping was enabled.
    
    Address by making TokenList.value a dynamically-computed property rather
    than a static attribute.
    living180 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    0e187cd View commit details
    Browse the repository at this point in the history