add support for LTC7841 #2397

MCabuena · 2024-12-12T02:31:47Z

Pull Request Description

Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

kister-jimenez · 2024-12-12T23:57:39Z

/AzurePipelines run

azure-pipelines · 2024-12-12T23:57:52Z

Azure Pipelines successfully started running 2 pipeline(s).

MCabuena · 2024-12-13T01:51:43Z

V2:

Removed from src.mk ltc7841_regs.c and ltc7841_regs.h requirement for building

kister-jimenez · 2024-12-13T02:01:32Z

/AzurePipelines run

azure-pipelines · 2024-12-13T02:01:45Z

Azure Pipelines successfully started running 2 pipeline(s).

MCabuena · 2024-12-13T09:03:35Z

V3:

fixed src.mk file inside ltc7841 project folder

kister-jimenez · 2024-12-13T09:25:07Z

/AzurePipelines run

azure-pipelines · 2024-12-13T09:25:20Z

Azure Pipelines successfully started running 2 pipeline(s).

CiprianRegus · 2024-12-13T09:10:00Z

drivers/power/ltc7841/ltc7841.h

@@ -0,0 +1,199 @@
+/***************************************************************************//**


This file has the old license. Use the 3 clause BSD instead.

CiprianRegus · 2024-12-13T09:11:00Z

drivers/power/ltc7841/ltc7841.c

+	uint8_t read_length;
+	uint8_t write_length = 1;
+	uint8_t size = get_register_size(cmd);
+	uint8_t write_buffer[write_length];


doesn't need to be an array

CiprianRegus · 2024-12-13T09:11:22Z

drivers/power/ltc7841/ltc7841.c

+	ret = no_os_i2c_write(desc->comm_desc, write_buffer, write_length, 0);
+	if (ret)
+		return ret;
+	// read part of write_read, 1 at the end for stop bit sending


Use /**/ comment style

CiprianRegus · 2024-12-13T09:11:43Z

drivers/power/ltc7841/ltc7841.c

+	if (ret)
+		return ret;
+	// read part of write_read, 1 at the end for stop bit sending
+	ret = no_os_i2c_read(desc->comm_desc, g_i2c0_read_buffer, read_length, 1);


You should store the register value in data.

CiprianRegus · 2024-12-13T09:20:56Z

drivers/power/ltc7841/ltc7841.c

+{
+	int ret;
+	/* Write register */
+	ret = ltc7841_reg_write(desc, LTC7841_OPERATION, LTC7841_OPERATION_MARGIN_LOW);


Return directly. There are other places where this is the case.

CiprianRegus · 2024-12-13T09:25:12Z

drivers/power/ltc7841/iio_ltc7841.c

+static struct iio_attribute ltc7841_chan_attrs[] = {
+	{
+		.name = "raw",
+		.show = ltc7841_iio_read_raw
+	},
+	END_ATTRIBUTES_ARRAY
+};


Is the scale of every channel equal to 1? Otherwise, you also need the scale attribute here.

The scale of every channel is the same at 10mV per bit.

on my next commit, I'll add as you stated below a scale attribute for the channel

When implementing review suggestions, you don't need to create a new commit (unless you add new functionality, which should have its own commit). Just modify the current one and push the changes again. After that, you should add a changelog comment in this PR stating what you did since the last push.

CiprianRegus · 2024-12-13T09:26:42Z

drivers/power/ltc7841/iio_ltc7841.c

+	struct ltc7841_iio_desc *iio_ltc7841 = dev;
+	struct ltc7841_desc *ltc7841 = iio_ltc7841->ltc7841_desc;
+
+	ret = ltc7841_reg_read(ltc7841, (uint8_t)reg, (uint8_t *)readval);


Use an intermediary uin8_t variable. Currently, you're passing a different memory location based on endianess.

CiprianRegus · 2024-12-13T09:28:04Z

drivers/power/ltc7841/iio_ltc7841.c

+	}
+	case LTC7841_IIO_IIN_CHAN:
+		ret = ltc7841_reg_read(ltc7841, (uint8_t)LTC7841_READ_IIN, read_value);
+		if (0 == ret) {


Use inverse logic:

if (ret) break;

CiprianRegus · 2024-12-13T09:31:13Z

drivers/power/ltc7841/iio_ltc7841.c

+	case LTC7841_IIO_IIN_CHAN:
+		ret = ltc7841_reg_read(ltc7841, (uint8_t)LTC7841_READ_IIN, read_value);
+		if (0 == ret) {
+			double current_value;


Use a lower unit (e.g microampere in this case), so you won't lose any digit during the division, and scale the result instead.

CiprianRegus · 2024-12-13T13:48:19Z

drivers/power/ltc7841/ltc7841.h

+#define PEC_SIZE                    0x100
+#define BYTE_LENGTH                 1
+#define WORD_LENGTH                 2


Add the LTC7841_ prefix. Otherwise, generic names like these could create conflicts with other macros.

CiprianRegus · 2024-12-13T13:51:06Z

projects/ltc7841/src/common/common_data.c

+	.max_speed_hz   = LTC7841_I2C_CLK_SPEED,
+	.slave_address  = LTC7841_I2C_ADDR,
+	.platform_ops   = &max_i2c_ops,
+	.extra          = (void *)&ltc7841_i2c_extra,


No need to cast.

MCabuena · 2024-12-17T03:49:15Z

V4:

changed commenting style to /* */
removed void in common_data.c for ltc7841_i2c_extra
removed PEC_SIZE since this device doesn't support PEC
added LTC7841_ name to BYTE_LENGTH and WORD_LENGTH in ltc7841.h
when computing for current input and current output, unit usage is now in uA for initial calculations, only when calculating for scale values does it show in A
changed iio_ltc7841.c all reverse logic for checking ret
added scaled value as an attribute
functions in ltc7841.c now return directly
changed write_buffer into a uint8_t type only, and not as an array
changed license file of ltc7841.h

buha · 2024-12-17T10:23:18Z

/AzurePipelines run

azure-pipelines · 2024-12-17T10:23:31Z

Azure Pipelines successfully started running 2 pipeline(s).

buha · 2024-12-17T12:40:59Z

drivers/power/ltc7841/ltc7841.c

+	}
+	return ret;
+}
+/**


it's a style remark but always leave a blank line from the closing bracket of a function to the next content like this

} /**

reason is, we want the code style to be consistent

buha · 2024-12-17T12:42:44Z

drivers/power/ltc7841/ltc7841.c

+	} else {
+		ret = -EINVAL;
+	}
+	return ret;


another style remark, it's kind of informal but we always put a blank line before the final return statement of the function like:

} return ret; }

buha · 2024-12-17T12:45:21Z

drivers/power/ltc7841/ltc7841.h

+ */
+struct ltc7841_init_param {
+	/* Device register settings */
+	struct ltc7841_reg_st *regs;


i cant find where this struct comes from

is the user supposed to provide the register configuration explicitly ? i dont think this approach is best, i think the driver should abstract away as much as possible the registers and not force the user to read the datasheet and provide register values

Hi buha,

It used to be that I have a list of registers I put on a list and populated that. I changed the approach and abstracted it. I wasn't able to remove it on this version of the commit.

I'll remove that part for the next version which I plan to also address your comments.

buha · 2024-12-17T12:46:28Z

projects/ltc7841/src.mk

+INCS += $(PROJECT)/src/platform/$(PLATFORM)/parameters.h
+SRCS += $(PROJECT)/src/platform/$(PLATFORM)/parameters.c
+
+INCS += $(INCLUDE)/no_os_delay.h     		\


use NO_OS_INC_DIRS instead of INCS, search no-OS github to see examples of its usage

buha · 2024-12-17T12:47:14Z

projects/ltc7841/src/platform/maxim/platform_src.mk

@@ -0,0 +1,16 @@
+INCS += $(PLATFORM_DRIVERS)/maxim_gpio.h      \


same here, NO_OS_INC_DIRS

MCabuena · 2024-12-18T02:24:40Z

V5:

changed src.mk file to use NO_OS_INC_DIRS instead of INC +=
removed ltc7841_reg_st inside ltc7841_init_param
added a blank space before the final return as suggested
added a space in between the {} of functions

kister-jimenez · 2024-12-18T02:26:19Z

/AzurePipelines run

azure-pipelines · 2024-12-18T02:26:32Z

Azure Pipelines successfully started running 2 pipeline(s).

buha · 2024-12-18T12:58:51Z

projects/ltc7841/src/common/common_data.h

+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *  - Redistributions of source code must retain the above copyright


you still have some of these old license headers, please check them all

buha · 2024-12-18T12:59:11Z

projects/ltc7841/src/examples/basic/basic_example.h

+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *  - Redistributions of source code must retain the above copyright


buha · 2024-12-18T12:59:29Z

projects/ltc7841/src/platform/maxim/parameters.c

+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *  - Redistributions of source code must retain the above copyright


this one, and potentially others

buha · 2024-12-18T13:00:25Z

projects/ltc7841/src/platform/platform_includes.h

+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *  - Redistributions of source code must retain the above copyright


buha · 2024-12-18T13:00:43Z

projects/ltc7841/src/platform/maxim/platform_src.mk

+        $(PLATFORM_DRIVERS)/../common/maxim_dma.h       \
+        $(PLATFORM_DRIVERS)/maxim_i2c.h       \
+        $(PLATFORM_DRIVERS)/maxim_uart.h      \
+        $(PLATFORM_DRIVERS)/maxim_uart_stdio.h


you still don't use NO_OS_INC_DIRS here

buha · 2024-12-18T13:08:06Z

projects/ltc7841/README.rst

+.. code-block:: bash
+
+	# Select the example you want to enable by choosing y for enabling and n for disabling
+	BASIC_EXAMPLE = y


i don't think editing Makefiles is good to set the example to build even though we have existing projects done this way... let's strive to make the user interaction easy so that they run one of these commands to choose the example to build:

make EXAMPLE=basic_example make EXAMPLE=iio_example

Basically you could default to basic like this:

EXAMPLE ?= basic_example

And take action based on it:

ifeq ($(EXAMPLE), iio_example) ... endif

drivers/power/ltc7841/iio_ltc7841.c

kister-jimenez · 2024-12-18T11:16:01Z

drivers/power/ltc7841/README.rst

+	struct ltc7841_init_param ltc7841_ip = {
+		.comm_param = {
+		.device_id      = LTC7841_I2C_DEVICE_ID,
+		.max_speed_hz   = LTC7841_I2C_CLK_SPEED,
+		.slave_address  = LTC7841_I2C_ADDR,
+		.platform_ops   = &max_i2c_ops,
+		.extra          = (void *)&ltc7841_i2c_extra,
+	    },
+	    .regs = ltc7841_regs
+	};


You'll probably have to update this to match your current init_param.

kister-jimenez · 2024-12-18T11:16:23Z

drivers/power/ltc7841/README.rst

+	if (ret)
+	{
+		goto error;
+	}


No need brackets for single-statement if/else

kister-jimenez · 2024-12-18T11:16:42Z

drivers/power/ltc7841/README.rst

+	struct ltc7841_iio_desc_init_param ltc7841_iio_ip = 
+    {
+		.ltc7841_init_param = &ltc7841_ip,
+	};


Formatting issues.

kister-jimenez · 2024-12-18T11:17:13Z

drivers/power/ltc7841/README.rst

+	if (ret)
+    {
+		goto exit;
+    }


formatting issue.

kister-jimenez · 2024-12-18T13:33:15Z

drivers/power/ltc7841/iio_ltc7841.c

+	.debug_attributes = ltc7841_debug_attrs,
+	.debug_reg_read = ltc7841_iio_reg_read,
+	.debug_reg_write = ltc7841_iio_reg_write,
+};


And extra newline at EOF.

kister-jimenez · 2024-12-18T13:36:04Z

projects/ltc7841/src.mk

+		$(NO-OS)/util/no_os_mutex.c	\
+		$(NO-OS)/util/no_os_crc8.c
+
+SRCS += $(DRIVERS)/power/ltc7841/ltc7841.c


Add extra newline

kister-jimenez · 2024-12-18T13:36:26Z

projects/ltc7841/src/common/common_data.c

+
+struct ltc7841_init_param ltc7841_ip = {
+	.comm_param = &ltc7841_i2c_ip
+};


Add extra newline

kister-jimenez · 2024-12-18T13:37:13Z

projects/ltc7841/src/examples/iio_example/iio_example.c

+	if (ret)
+		pr_err("Error!\n");
+	return ret;
+}


Add extra newline

kister-jimenez · 2024-12-18T13:41:11Z

drivers/power/ltc7841/ltc7841.h

+enum ltc7841_registers {
+	LTC7841_OPERATION = 1,
+	LTC7841_VOUT_MODE = 0x20,
+	LTC7841_STATUS_WORD = 0x79,
+	LTC7841_READ_VIN = 0x88,
+	LTC7841_READ_IIN = 0x89,
+	LTC7841_READ_VOUT = 0x8B,
+	LTC7841_READ_IOUT = 0x8C,
+	LTC7841_READ_TEMPERATURE_1 = 0x8D,
+	LTC7841_PMBUS_REVISION = 0x98,
+	LTC7841_MFR_IOUT_PEAK = 0xD7,
+	LTC7841_MFR_VOUT_PEAK = 0xDD,
+	LTC7841_MFR_VIN_PEAK = 0xDE,
+	LTC7841_MFR_TEMEPRATURE1_PEAK = 0xDF,
+	LTC7841_MFR_IIN_PEAK = 0xE1,
+	LTC7841_MFR_CLEAR_PEAKS = 0xE3,
+	LTC7841_MFR_VOUT_MARGIN_HIGH = 0xE5,
+	LTC7841_MFR_SPECIAL_ID = 0xE7,
+	LTC7841_MFR_VOUT_COMMAND = 0xE8,
+	LTC7841_MFR_CONFIG = 0xE9,
+	LTC7841_MFR_VOUT_MARGIN_LOW = 0xED,
+	LTC7841_MFR_RAIL_ADDRESS = 0xFA,
+	LTC7841_MFR_RESET = 0xFD
+};


You may want to follow this: https://github.com/analogdevicesinc/no-OS/blob/a75c351f56ab2699d7b0fe8623ffcaf4e867f6ec/drivers/power/lt7182s/lt7182s.h#L50C1-L170C33

For consistency across PMBUS devices and other no-OS drivers.

MCabuena · 2024-12-19T07:19:40Z

I wanted to re-open this pull request

MCabuena · 2024-12-19T07:25:27Z

V6:

changed enum registers for pmbus into # define
changed, checked and re-checked files to use BSD 3 clause for license files
adjusted driver README.rst to reflect the current ltc7841.h file
adjusted project README.rst to instruct using new command for building the examples, adding a variable of EXAMPLE=IIO_EXAMPLE or EXAMPLE=BASIC_EXAMPLE
changed examples_src.mk to use NO_OS_INC_DIRS
changed examples_src.mk to check if EXAMPLE variable is equal to IIO_EXAMPLE or EXAMPLE is equal to BASIC_EXAMPLE
added blank line in files as the last line
added space before final return

kister-jimenez · 2024-12-19T08:23:10Z

/AzurePipelines run

azure-pipelines · 2024-12-19T08:23:22Z

Azure Pipelines successfully started running 2 pipeline(s).

Add initial header and source files for LTC7841 driver. Signed-off-by: Marvin Neil Cabuenas <[email protected]>

Add initial header and source file for LTC7841 IIO driver. Signed-off-by: Marvin Neil Cabuenas <[email protected]>

Add README.rst documentation file for LTC7841 alongside other documentation related files. Signed-off-by: Marvin Neil Cabuenas <[email protected]>

Add initial project files for both basic and IIO examples for LTC7841. Signed-off-by: Marvin Neil Cabuenas <[email protected]>

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Marvin Neil Cabuenas <[email protected]>

MCabuena · 2024-12-19T23:48:05Z

V7:

changed builds.json to add new EXAMPLE variable, EXAMPLE=BASIC_EXAMPLE for basic example and EXAMPLE=IIO_EXAMPLE for iio example

kister-jimenez · 2024-12-20T01:23:52Z

/AzurePipelines run

azure-pipelines · 2024-12-20T01:24:07Z

Azure Pipelines successfully started running 2 pipeline(s).

kister-jimenez

There are still previous comments that have not been addressed in this revision. Please address and resolve them all.

kister-jimenez · 2024-12-20T07:01:17Z

projects/ltc7841/src/examples/examples_src.mk

@@ -0,0 +1,24 @@
+ifeq ($(EXAMPLE), IIO_EXAMPLE))


remove extra ')'

kister-jimenez · 2024-12-20T07:01:30Z

projects/ltc7841/src/examples/examples_src.mk

+SRCS += $(PROJECT)/src/examples/iio_example/iio_example.c
+endif
+
+ifeq ($(EXAMPLE), BASIC_EXAMPLE))


remove extra ')'

kister-jimenez · 2024-12-20T07:02:29Z

projects/ltc7841/Makefile

+BASIC_EXAMPLE = n
+IIO_EXAMPLE = y


You need to remove this and replace with maybe a default like this:
EXAMPLE ?= IIO_EXAMPLE

kister-jimenez · 2024-12-20T07:05:52Z

projects/ltc7841/src/platform/maxim/main.c

+#endif
+
+#if (BASIC_EXAMPLE + IIO_EXAMPLE == 0)
+#error At least one example has to be selected using y value in Makefile.


Need to update error messages because EXAMPLE is now passed as an argument to make instead of editing the makefile.
e.g.

Select an example by passing the type of EXAMPLE in the make command. For example:
make EXAMPLE=IIO_EXAMPLE

kister-jimenez · 2024-12-20T07:07:55Z

drivers/power/ltc7841/iio_ltc7841.c

+ * @return ret    - Result of the reading procedure.
+ * 		    In case of success, the size of the read data is returned.
+*/
+//static


//static is still present

kister-jimenez · 2024-12-20T07:11:04Z

drivers/power/ltc7841/ltc7841.c

+{
+	struct ltc7841_desc *dev;
+	int ret;
+	/* ltc7841 only needs sda, scl and ground connection to the microcontroller*/


I don't think this comment is necessary. You can remove this.

kister-jimenez · 2024-12-20T07:12:34Z

drivers/power/ltc7841/ltc7841.c

+	/* I2C write target address */
+	read_length = size;
+	write_buffer = cmd;
+	/* write part of write_read, 0 at the end for no stop bit */


You can remove this comment because these can be inferred from line.

kister-jimenez · 2024-12-20T07:12:44Z

drivers/power/ltc7841/ltc7841.c

+	ret = no_os_i2c_write(desc->comm_desc, &write_buffer, 1, 0);
+	if (ret)
+		return ret;
+	/* read part of write_read, 1 at the end for stop bit sending */


You can remove this comment as well.

kister-jimenez · 2024-12-20T07:13:12Z

drivers/power/ltc7841/ltc7841.c

+	// apply a 7 bit mask since bit 7 needs to be held low to enable communication
+	addr &= LTC7841_7_BIT_ADDRESS_MASK;
+
+	/* Write register */


you can remove this comment.

kister-jimenez · 2024-12-20T07:13:38Z

drivers/power/ltc7841/ltc7841.c

+ */
+int ltc7841_change_rail_address(struct ltc7841_desc *desc, uint8_t addr)
+{
+	// apply a 7 bit mask since bit 7 needs to be held low to enable communication


you can remove this comment.

buha · 2024-12-20T13:23:04Z

projects/ltc7841/Makefile

@@ -0,0 +1,9 @@
+# Select the example you want to enable by choosing y for enabling and n for disabling
+BASIC_EXAMPLE = n


Please see this pull request and use it as a template: #2368

The idea is that the user types EXAMPLE=basic or EXAMPLE=iio_example, these being the names of the folders where you put the example code. We will create some infrastructure to do this automatically, but for now you'll have to do it manually.

MCabuena marked this pull request as ready for review December 12, 2024 02:33

MCabuena requested review from buha, CiprianRegus, dbogdan, amiclaus, rbolboac and danmois as code owners December 12, 2024 02:33

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from fcc8863 to 5b005cb Compare December 13, 2024 01:40

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from c57b81e to 16af219 Compare December 13, 2024 08:46

CiprianRegus reviewed Dec 13, 2024

View reviewed changes

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from 298e71f to 6423294 Compare December 17, 2024 03:34

buha reviewed Dec 17, 2024

View reviewed changes

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from 34f8560 to 3674149 Compare December 18, 2024 02:13

buha reviewed Dec 18, 2024

View reviewed changes

kister-jimenez reviewed Dec 18, 2024

View reviewed changes

MCabuena closed this Dec 19, 2024

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from 116c2e8 to cc73a3d Compare December 19, 2024 05:29

MCabuena reopened this Dec 19, 2024

MCabuena added 5 commits December 20, 2024 07:32

drivers: power: ltc7841: Add driver support for LTC7841

89f7cee

Add initial header and source files for LTC7841 driver. Signed-off-by: Marvin Neil Cabuenas <[email protected]>

drivers: power: ltc7841: Add IIO support for LTC7841

73a8ff4

Add initial header and source file for LTC7841 IIO driver. Signed-off-by: Marvin Neil Cabuenas <[email protected]>

drivers: power: ltc7841: Add README documentation for LTC7841

92add3f

Add README.rst documentation file for LTC7841 alongside other documentation related files. Signed-off-by: Marvin Neil Cabuenas <[email protected]>

projects: ltc7841: Add project for LTC7841

ac9a2c9

Add initial project files for both basic and IIO examples for LTC7841. Signed-off-by: Marvin Neil Cabuenas <[email protected]>

projects: ltc7841: Add README documentation for project

f3e43f0

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Marvin Neil Cabuenas <[email protected]>

MCabuena force-pushed the ltc7841_my_changes_to_run_ci branch from 06fb555 to f3e43f0 Compare December 19, 2024 23:46

kister-jimenez reviewed Dec 20, 2024

View reviewed changes

buha reviewed Dec 20, 2024

View reviewed changes

		@@ -0,0 +1,199 @@
		/*************************************************************************//

		@@ -0,0 +1,9 @@
		# Select the example you want to enable by choosing y for enabling and n for disabling
		BASIC_EXAMPLE = n

add support for LTC7841 #2397

Are you sure you want to change the base?

add support for LTC7841 #2397

Conversation

MCabuena commented Dec 12, 2024 • edited Loading

Pull Request Description

PR Type

PR Checklist

kister-jimenez commented Dec 12, 2024

azure-pipelines bot commented Dec 12, 2024

MCabuena commented Dec 13, 2024

kister-jimenez commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

MCabuena commented Dec 13, 2024

kister-jimenez commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MCabuena commented Dec 17, 2024

buha commented Dec 17, 2024

azure-pipelines bot commented Dec 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MCabuena commented Dec 18, 2024

kister-jimenez commented Dec 18, 2024

azure-pipelines bot commented Dec 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buha Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MCabuena commented Dec 19, 2024

MCabuena commented Dec 19, 2024

kister-jimenez commented Dec 19, 2024

azure-pipelines bot commented Dec 19, 2024

MCabuena commented Dec 19, 2024

kister-jimenez commented Dec 20, 2024

azure-pipelines bot commented Dec 20, 2024

kister-jimenez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MCabuena commented Dec 12, 2024 •

edited

Loading

buha Dec 18, 2024 •

edited

Loading