DRAFT: add AD7173 family #42
Conversation
* AD4111 12 channel (8 voltage/4 current) +1 temperature Signed-off-by: Guillaume Ranquet <[email protected]>
|
|
| % SamplesPerFrame Samples Per Frame | ||
| % Number of samples per frame, specified as an even positive | ||
| % integer. | ||
| SamplesPerFrame = 400 |
There was a problem hiding this comment.
Not sure I understand where the SampleRate/SamplesPerFrame default values come from?
| properties (Nontunable, Hidden) | ||
| Timeout = Inf | ||
| kernelBuffersCount = 1 | ||
| dataTypeStr = 'int32' |
There was a problem hiding this comment.
is int32 the best type available? most devices declare realbits to 24 and ad4113 is 16 bits
| %% Check Voltage Scale | ||
| function rValue = get.VoltageScale(obj) | ||
| if obj.ConnectedToDevice | ||
| rValue = obj.getAttributeDouble('voltage0', 'scale', obj.isOutput); |
There was a problem hiding this comment.
the default of 'voltage0' might not exists depending on how the dtb is written, how to account for that? I see GetChannelAttrValue() exists in +Generic/Rx.m but I'm unsure how to get the chnID from the first enabled channel?
| function updateBuildInfo(buildInfo, bldCfg) | ||
| % Call the matlabshared.libiio.method first | ||
| matlabshared.libiio.ExternalDependency.updateBuildInfo(buildInfo, bldCfg); | ||
| end |
There was a problem hiding this comment.
not sure what all this boilerplate is doing!?
| channel_names = {'voltage0','voltage1','voltage2','voltage3',... | ||
| 'voltage4','voltage5','voltage6','voltage7','current0', ... | ||
| 'current1','current2','current3','differential0', ... | ||
| 'differential1','differential2','differential3', 'temp'}; |
There was a problem hiding this comment.
the channels will not be named differentialX but something like in_voltage3-voltage5_raw
I'm unsure how to translate this here? other devices in the toolbox seems to use differentialX, not sure how this works?
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist