AD7124: update code to match newer linux drivers #39
Conversation
In newer versions of the AD7124 driver, the sampling_frequency is no longer a device-level attribute, but a per-channel attribute. This means that the AD7124 base driver should set this attribute for all enabled channels. Signed-off-by: Alexandru Ardelean <[email protected]>
In a newer version of the AD7124 driver, the channels were all made differential. That means that the channel names need to be updated. This change updates the channel names to the new (differential channel names). Signed-off-by: Alexandru Ardelean <[email protected]>
commodo
requested review from
ribdp,
SaikiranGudla and
jansunil
as code owners
| channel_names = {'voltage0','voltage1','voltage2','voltage3',... | ||
| 'voltage4','voltage5','voltage6','voltage7','voltage8','voltage9',... | ||
| 'voltage10','voltage11','voltage12','voltage13','voltage14','voltage15'}; | ||
| channel_names = {'voltage0-voltage1','voltage2-voltage3',... |
There was a problem hiding this comment.
Out of curiosity- why do the channel names look different here? the Shouldn't the differential configuration be considered in the fW?
There was a problem hiding this comment.
well, it's how the implementation of the AD7124 driver is, in the Linux IIO framework;
since the inputs on the AD7124 are differential, the IIO framework decided to represented this as 2 channel-pairs (i.e. voltage0-voltage1 and so on); this is how they show up, when a channel is defined as differential;
what puzzles me, is why this was represented as voltage0','voltage1, etc in the first place
the AD7124 driver has been implemented in Linux (as differential) for a number of years;
so, the channels should have looked more like 'voltage0-voltage1','voltage2-voltage3',
unless, the no-OS implementation was used to test this initially;
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist