fix(formats): handle DTCG-format tokens in typescript/es6-declarations #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Also looks good to me, same comment as the other PR about adding a changeset :) |
dbanksdesign
previously approved these changes
Dec 9, 2024
- add functionalty to handle comment and $description - update tests - update snapshots Signed-off-by: Tobias Kuppens Groot <[email protected]>
tkgroot
force-pushed
the
fix/dtcg-formats-typescript-es6-declarations
branch
from
fd8985a to
2966cfd
Compare
|
added changeset and rebased onto latest of main, to resolve merge-conflicts |
jorenbroekema
approved these changes
Dec 10, 2024
dbanksdesign
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
the current "typescript/es6-declarations" formatter does not handle DTCG formatted tokens, namely the
commentor$descriptionattribute of a token respectively.outputStringLiterals = falseBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.