-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to eslint v9 and migrate to flatconfig #1386
chore: upgrade to eslint v9 and migrate to flatconfig #1386
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I migrated a bunch of repos to ESLint v9 recently and contemplated doing it for Style Dictionary but couldn't find the time for it, so this is much appreciated.
Just 1 suggestion for patching globals@11 version
9902598
to
3b74836
Compare
Thanks for the suggestion! I've just patched the globals@11 and rebased onto main. I think the package-lock(v4.1.4) and package.json(v4.2.0) are out of sync tho @jorenbroekema |
I think the package-lock version gets out of sync quite a bit because during the version bump the package-lock would have to be synced by doing an npm install after the bump in package.json and committing that with the version bump, I guess our release orchestration (changesets) isn't doing this. It's not a problem imo but could be solved by doing npm install after rebasing on latest main and committing the pkg lock version bump. Not a blocker for me though EDIT: #1387 fixed here for in the future. |
Description of changes:
This PR upgrades ESLint to version 9 and migrates to the new flat-config format, which has been the default configuration format since ESLint v9.0.0.
The
.eslintrc.json
file has been removed in favor of the neweslint.config.js
file.Following packages has been adjusted to make this migration possible:
Patched the globals@11 to make linter happy
patches/globals+11.12.0.patch
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.