chore(docs): updating docs styling #1270
Open
+2,405
−687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you need a hand solving the CI issues 👍🏻 or when it's ready for review |
There was a problem hiding this comment.
Just a couple of comments from me trying to fix the type issues.
I pushed a commit as well:
- fix types issues
- made sure that docs:buid:tokens is done on postinstall since you kinda need these to be built for typescript to be happy, for docs:start/preview/build to function properly, etc.
- install missing dependencies
- temp revert to the png logo since the svg is missing for me
- bump memfs to get around a type issue, although this is also fixed in another PR
- bump starlight coz the Badge component wasn't exported in the older version
Hopefully this helps speed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Preview: https://docs-v4.d16eby4ekpss5y.amplifyapp.com/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.