Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump pandas version limit #2254

Merged
merged 14 commits into from
Jul 18, 2024

Conversation

HaoXuAI
Copy link
Contributor

@HaoXuAI HaoXuAI commented Jul 1, 2024

Description

Motivation and Context

Follow up on PR: #1858, this bump the pandas upper limit to 2.2.2.

How Has This Been Tested?

Documentation

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@HaoXuAI HaoXuAI requested a review from a team as a code owner July 1, 2024 21:39
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Jul 1, 2024
Copy link

boring-cyborg bot commented Jul 1, 2024

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

@kristenarmes
Copy link
Contributor

hi @HaoXuAI thanks for the PR, I approved the checks to run, but based on the failures it looks like the feast version might be too low if you want to try to upgrade that version too

Signed-off-by: cmuhao <[email protected]>
@HaoXuAI
Copy link
Contributor Author

HaoXuAI commented Jul 2, 2024

hi @HaoXuAI thanks for the PR, I approved the checks to run, but based on the failures it looks like the feast version might be too low if you want to try to upgrade that version too

@kristenarmes thanks. trying to bump the version for feast

Signed-off-by: cmuhao <[email protected]>
Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the persistence in fixing the errors, LGTM

@kristenarmes kristenarmes merged commit 74212e2 into amundsen-io:main Jul 18, 2024
10 checks passed
Copy link

boring-cyborg bot commented Jul 18, 2024

Awesome work, congrats on your first merged pull request!

@HaoXuAI
Copy link
Contributor Author

HaoXuAI commented Jul 18, 2024

@kristenarmes thanks! When would you cut a release to make the change alive?

@kristenarmes
Copy link
Contributor

@HaoXuAI sorry should have commented that on the original PR, could you bump the version here? and then I will approve/cut the release

@HaoXuAI
Copy link
Contributor Author

HaoXuAI commented Jul 18, 2024

@HaoXuAI sorry should have commented that on the original PR, could you bump the version here? and then I will approve/cut the release

no worries and yeah for sure, 7.5.6 or 7.4.7?

@kristenarmes
Copy link
Contributor

no worries and yeah for sure, 7.5.6 or 7.4.7?

let's do 7.5.0, thanks!

@HaoXuAI HaoXuAI mentioned this pull request Jul 18, 2024
4 tasks
@HaoXuAI
Copy link
Contributor Author

HaoXuAI commented Jul 18, 2024

no worries and yeah for sure, 7.5.6 or 7.4.7?

let's do 7.5.0, thanks!

sounds good. updated here: #2256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants