Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade flask to 2.2.5 and remove py37 support #2224

Closed
wants to merge 9 commits into from
Closed

chore: Upgrade flask to 2.2.5 and remove py37 support #2224

wants to merge 9 commits into from

Conversation

kristenarmes
Copy link
Contributor

@kristenarmes kristenarmes commented Dec 20, 2023 •
edited
Loading

Description

This change upgrades flask to version 2.2.5 and upgrades its related dependencies. The newer version of werkzeug was not compatible with python 3.7, so also removing support for that here since it is no longer widely supported anyway.

  • Upgrading flask to 2.2.5
  • werkzeug was subsequently upgraded to 3.0.1, which is not compatible with py37 so removing py37 support
  • With removal of py37, needed to upgrade mypy, leading to various mypy fixes

Motivation and Context

We are going to be upgrading our services to py3.10 soon, and we ran into some issues with the older version of flask. This change will also help resolve some security vulnerabilities for the project and remove outdated support.

How Has This Been Tested?

I installed the requirements files locally and ran our 3 services (frontend, search, and metadata) to make sure the build worked and to test them manually.

Documentation

N/A

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder area:metadata From the metadata folder area:search From the search folder labels Dec 20, 2023
@boring-cyborg boring-cyborg bot added area:common From common folder area:databuilder From databuilder folder area:dev-tools area:docs labels Dec 20, 2023
@kristenarmes kristenarmes changed the title chore: Upgrade flask to 2.2.5 and related dependencies chore: Upgrade flask to 2.2.5 and remove py38 support Dec 20, 2023
@kristenarmes kristenarmes changed the title chore: Upgrade flask to 2.2.5 and remove py38 support chore: Upgrade flask to 2.2.5 and remove py37 support Dec 20, 2023
@kristenarmes
Copy link
Contributor Author

Made these changes in incremental PRs, closing this one

@kristenarmes kristenarmes deleted the karmes-upgrade-flask branch April 4, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao will be requested when the pull request is marked ready for review feng-tao is a code owner

@jinhyukchang jinhyukchang Awaiting requested review from jinhyukchang jinhyukchang will be requested when the pull request is marked ready for review jinhyukchang is a code owner

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez will be requested when the pull request is marked ready for review allisonsuarez is a code owner

@verdan verdan Awaiting requested review from verdan verdan will be requested when the pull request is marked ready for review verdan is a code owner

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin will be requested when the pull request is marked ready for review bolkedebruin is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 will be requested when the pull request is marked ready for review mgorsk1 is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd will be requested when the pull request is marked ready for review youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma will be requested when the pull request is marked ready for review dechoma is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw will be requested when the pull request is marked ready for review sewardgw is a code owner

@dkunitsk dkunitsk Awaiting requested review from dkunitsk dkunitsk will be requested when the pull request is marked ready for review dkunitsk is a code owner

@ozandogrultan ozandogrultan Awaiting requested review from ozandogrultan ozandogrultan will be requested when the pull request is marked ready for review ozandogrultan is a code owner

@B-T-D B-T-D Awaiting requested review from B-T-D B-T-D will be requested when the pull request is marked ready for review B-T-D is a code owner

@ttannis ttannis Awaiting requested review from ttannis ttannis will be requested when the pull request is marked ready for review ttannis is a code owner

Assignees
No one assigned
Labels
area:common From common folder area:databuilder From databuilder folder area:dev-tools area:docs area:frontend From the Frontend folder area:metadata From the metadata folder area:search From the search folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kristenarmes