Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make sqlalchemy_extractor compatible with sqlalchemy>=1.4 #2209

Closed
wants to merge 5 commits into from
Closed

feat: Make sqlalchemy_extractor compatible with sqlalchemy>=1.4 #2209

wants to merge 5 commits into from

Conversation

mikekutzma
Copy link
Contributor

feat: Make sqlalchemy_extractor compatible with sqlalchemy>=1.4

Description

These changes to the sql_alchemy_extractor module allow for using the extractors with updated versions of sqlalchemy.

Motivation and Context

This addresses issues such as

How Has This Been Tested?

Tested using sampple_mssql_metadata.py script for

  • SQLAlchemy==1.3.16
  • SQLAlchemy==2.0.23

Documentation

None

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@mikekutzma mikekutzma requested a review from a team as a code owner November 12, 2023 17:32
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Nov 12, 2023
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Nov 12, 2023

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

@mikekutzma mikekutzma force-pushed the feature/databuilder-sqlalchemy-compatibility branch from 0862e98 to ff3d59a Compare November 14, 2023 14:29
@Golodhros
chore: update actions versions (amundsen-io#2211)
402f63a 
* chore: update actions versions

Signed-off-by: Marcos Iglesias <[email protected]>

* chore: updates Go version to 1.17

Signed-off-by: Marcos Iglesias <[email protected]>

---------

Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros
Copy link
Member

Please rebase with master to fix the checks!

Golodhros and others added 3 commits November 15, 2023 08:47
@Golodhros
chore: Update OWNERS.md adding Alagappan (amundsen-io#2208)
b832431 
Adding Alagappan as core maintainer of Amundsen

Signed-off-by: Marcos Iglesias <[email protected]>
@mikekutzma
[ADD] Make sqlalchemy_extractor compatible with sqlalchemy>=1.4
3ced3a9 
Signed-off-by: mikekutzma <[email protected]>
@mikekutzma
Merge branch 'feature/databuilder-sqlalchemy-compatibility' of github…
2e0d828 
….com:mikekutzma/amundsen into feature/databuilder-sqlalchemy-compatibility
@mikekutzma mikekutzma mentioned this pull request Nov 16, 2023
Merged
4 tasks
@mikekutzma
Copy link
Contributor Author

Moved to #2213

@mikekutzma mikekutzma closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:databuilder From databuilder folder area:dev-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikekutzma @Golodhros