Skip to content

Commit

Permalink
fix test
Browse files Browse the repository at this point in the history
Signed-off-by: Kristen Armes <[email protected]>
  • Loading branch information
kristenarmes committed Apr 4, 2024
1 parent 1183c03 commit 0315bcb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 3 additions & 5 deletions databuilder/tests/unit/rest_api/test_query_merger.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def test_ensure_record_get_updated(self) -> None:
results[1],
)

def test_exception_rasied_with_duplicate_merge_key(self) -> None:
def test_exception_raised_with_duplicate_merge_key(self) -> None:
"""
Two records in query_to_merge results have {'dashboard_id': 'd2'},
exception should be raised
Expand All @@ -70,8 +70,7 @@ def test_exception_rasied_with_duplicate_merge_key(self) -> None:
query = RestApiQuery(query_to_join=self.query_to_join, url=self.url, params={},
json_path=self.json_path, field_names=self.field_names,
query_merger=query_merger)
with self.assertRaises(Exception):
query.execute()
self.assertRaises(Exception, query.execute()) # type: ignore

def test_exception_raised_with_missing_merge_key(self) -> None:
"""
Expand All @@ -93,8 +92,7 @@ def test_exception_raised_with_missing_merge_key(self) -> None:
query = RestApiQuery(query_to_join=self.query_to_join, url=self.url, params={},
json_path=self.json_path, field_names=self.field_names,
query_merger=query_merger)
with self.assertRaises(Exception):
query.execute()
self.assertRaises(Exception, query.execute()) # type: ignore


if __name__ == '__main__':
Expand Down
2 changes: 1 addition & 1 deletion metadata/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ disallow_untyped_defs = True
ignore_missing_imports = True
strict_optional = True
warn_no_return = True
follow_imports = True
follow_imports = skip
exclude = venv

[semantic_release]
Expand Down

0 comments on commit 0315bcb

Please sign in to comment.