Add Python 3 support #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also came up in #51. Making this one line change is all that is needed in this repository, I have tested the plugin with this change and it works fine otherwise on Python 3.x. After this is merged, another PR will be needed to add this: compatibility:
python: ">=2.7,<4"To https://github.com/OctoPrint/plugins.octoprint.org/blob/gh-pages/_plugins/eeprom_marlin.md |
|
Picked this contribution into my fork of the plugin, https://github.com/cp2004/OctoPrint-EEPROM-Marlin/ You can see what I am currently developing in the ticket here cp2004/OctoPrint-EEPROM-Marlin#1 Will be trying to transfer the plugin repository to point to my fork in a weeks time, since it seems abandoned here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.