-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make checks individual #1172
base: main
Are you sure you want to change the base?
make checks individual #1172
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1172 +/- ##
=======================================
Coverage 90.19% 90.19%
=======================================
Files 83 83
Lines 1203 1203
=======================================
Hits 1085 1085
Misses 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
As an update, I think it would be better to make a plan for recategorising things before actually implementing the changes. Ideally, there will be some kind of framework as to what kind of checks are supported and determining where they belong. Categoriesnytelife26@[Elysian] » ls | where type == dir | skip | get name
╭────┬───────────────────╮
│ 0 │ airlinese │
│ 1 │ annotations │
│ 2 │ archaism │
│ 3 │ cliches │
│ 4 │ consistency │
│ 5 │ corporate_speak │
│ 6 │ cursing │
│ 7 │ dates_times │
│ 8 │ hedging │
│ 9 │ hyperbole │
│ 10 │ inprogress │
│ 11 │ jargon │
│ 12 │ lexical_illusions │
│ 13 │ lgbtq │
│ 14 │ links │
│ 15 │ malapropisms │
│ 16 │ misc │
│ 17 │ mixed_metaphors │
│ 18 │ mondegreens │
│ 19 │ needless_variants │
│ 20 │ nonwords │
│ 21 │ oxymorons │
│ 22 │ psychology │
│ 23 │ redundancy │
│ 24 │ security │
│ 25 │ sexism │
│ 26 │ skunked_terms │
│ 27 │ spelling │
│ 28 │ terms │
│ 29 │ typography │
│ 30 │ uncomparables │
│ 31 │ weasel_words │
╰────┴───────────────────╯ Squash
UncertainI think a lot of the content of |
This relates to...
The structure of checks directories.
Related issues:
Rationale
At present, some subcheck files (e.g.
typography.symbols
,redundancy.misc
)contain multiple subchecks. This is an illogical structure, prevents disabling
the subchecks in
.proselintrc
which should be possible, et cetera. This PRfixes that by moving them into individual subcheck files, where they belong.
Changes
N/A (WIP).
Features
N/A.
Bug Fixes
N/A.
Breaking Changes and Deprecations
N/A.