Skip to content

Commit

Permalink
[SPARK-17639][BUILD] Add jce.jar to buildclasspath when building.
Browse files Browse the repository at this point in the history
This was missing, preventing code that uses javax.crypto to properly
compile in Spark.

Author: Marcelo Vanzin <[email protected]>

Closes apache#15204 from vanzin/SPARK-17639.
  • Loading branch information
Marcelo Vanzin committed Sep 23, 2016
1 parent 79159a1 commit a4aeb76
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
4 changes: 1 addition & 3 deletions core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,6 @@
</os>
</activation>
<properties>
<path.separator>\</path.separator>
<script.extension>.bat</script.extension>
</properties>
</profile>
Expand All @@ -429,7 +428,6 @@
</os>
</activation>
<properties>
<path.separator>/</path.separator>
<script.extension>.sh</script.extension>
</properties>
</profile>
Expand All @@ -450,7 +448,7 @@
</execution>
</executions>
<configuration>
<executable>..${path.separator}R${path.separator}install-dev${script.extension}</executable>
<executable>..${file.separator}R${file.separator}install-dev${script.extension}</executable>
</configuration>
</plugin>
</plugins>
Expand Down
7 changes: 4 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2617,8 +2617,9 @@
<configuration>
<compilerArgs combine.children="append">
<arg>-bootclasspath</arg>
<arg>${env.JAVA_7_HOME}/jre/lib/rt.jar</arg>
<arg>${env.JAVA_7_HOME}/jre/lib/rt.jar${path.separator}${env.JAVA_7_HOME}/jre/lib/jce.jar</arg>
</compilerArgs>
<verbose>true</verbose>
</configuration>
</plugin>
<plugin>
Expand All @@ -2633,7 +2634,7 @@
<configuration>
<args combine.children="append">
<arg>-javabootclasspath</arg>
<arg>${env.JAVA_7_HOME}/jre/lib/rt.jar</arg>
<arg>${env.JAVA_7_HOME}/jre/lib/rt.jar${path.separator}${env.JAVA_7_HOME}/jre/lib/jce.jar</arg>
</args>
</configuration>
</execution>
Expand All @@ -2642,7 +2643,7 @@
<configuration>
<args combine.children="append">
<arg>-javabootclasspath</arg>
<arg>${env.JAVA_7_HOME}/jre/lib/rt.jar</arg>
<arg>${env.JAVA_7_HOME}/jre/lib/rt.jar${path.separator}${env.JAVA_7_HOME}/jre/lib/jce.jar</arg>
</args>
</configuration>
</execution>
Expand Down
4 changes: 2 additions & 2 deletions project/SparkBuild.scala
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ object SparkBuild extends PomBuild {
"-target", javacJVMVersion.value
) ++ sys.env.get("JAVA_7_HOME").toSeq.flatMap { jdk7 =>
if (javacJVMVersion.value == "1.7") {
Seq("-bootclasspath", s"$jdk7/jre/lib/rt.jar")
Seq("-bootclasspath", s"$jdk7/jre/lib/rt.jar${File.pathSeparator}$jdk7/jre/lib/jce.jar")
} else {
Nil
}
Expand All @@ -291,7 +291,7 @@ object SparkBuild extends PomBuild {
"-sourcepath", (baseDirectory in ThisBuild).value.getAbsolutePath // Required for relative source links in scaladoc
) ++ sys.env.get("JAVA_7_HOME").toSeq.flatMap { jdk7 =>
if (javacJVMVersion.value == "1.7") {
Seq("-javabootclasspath", s"$jdk7/jre/lib/rt.jar")
Seq("-javabootclasspath", s"$jdk7/jre/lib/rt.jar${File.pathSeparator}$jdk7/jre/lib/jce.jar")
} else {
Nil
}
Expand Down

0 comments on commit a4aeb76

Please sign in to comment.