Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing: refactor to follow typeshed #67

Merged
merged 3 commits into from
Sep 10, 2024
Merged

typing: refactor to follow typeshed #67

merged 3 commits into from
Sep 10, 2024

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Sep 9, 2024 •
edited
Loading

typeshed use builtins.int and builtins.bytes to avoid name collision

https://github.com/python/typeshed/blob/main/stdlib/uuid.pyi

aminalaee
aminalaee approved these changes Sep 10, 2024
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@aminalaee aminalaee changed the title refactor typing, follow typeshed typing: refactor to follow typeshed Sep 10, 2024
@aminalaee aminalaee merged commit 3ff08f6 into aminalaee:main Sep 10, 2024
19 checks passed
@trim21 trim21 deleted the typing branch September 10, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trim21 @aminalaee