-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zmp generator and populate all outputs of the unycycle trajectory generator #916
base: master
Are you sure you want to change the base?
Add zmp generator and populate all outputs of the unycycle trajectory generator #916
Conversation
03e1d0e
to
7f78303
Compare
At the code level, it looks good. What I am a bit afraid of is that from outside it is not clear that the different trajectories are not coherent with each other. At the unicycle planner level, you are calling to different generators, so somehow you can expect them to be separate. Here instead, the output is in a single data structure. Maybe it would be useful to have a trigger to turn on or off this output? |
You're right! It makes totally sense. With the commit ecbd51f I tried to make the I like the fact that There's the drawback. This change makes the blf Unicycle Trajectory Generator not backward compatible. But I think the number of users is still low. Let me know what you think. |
It should be fine by changing the version number. On the other hand, another alternative is to apply this change only for the data you added |
Some of the outputs of the
UnicycleTrajectoryGenerator
were not being populated.This PR fixes it.
Moreover, the
ZMP generator
(and its outputs) is added to theUnicycleTrajectoryGenerator