-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce latency of YarpLoggerDevice #883
Draft
LoreMoretti
wants to merge
14
commits into
ami-iit:master
Choose a base branch
from
LoreMoretti:feature/YarpLoggerDevice/RealTime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Reduce latency of YarpLoggerDevice #883
LoreMoretti
wants to merge
14
commits into
ami-iit:master
from
LoreMoretti:feature/YarpLoggerDevice/RealTime
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoreMoretti
requested review from
GiulioRomualdi and
S-Dafarra
as code owners
September 12, 2024 16:28
LoreMoretti
force-pushed
the
feature/YarpLoggerDevice/RealTime
branch
from
September 12, 2024 16:33
59e11f6
to
088b6e9
Compare
S-Dafarra
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Just a couple of minor comments
S-Dafarra
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #877, this PR aims at reduce the latency of
YarpLoggerDevice
when logging data with high sample rates (e.g.1 kHz
).The user can enable this feature (which by default is disabled) setting the
enable_real_time_scheduling
totrue
.