Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 32 #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issue 32 #33

wants to merge 2 commits into from

Conversation

joarfish
Copy link

@joarfish joarfish commented Jan 5, 2020

This is a proposal for solving #32

@happenslol
Copy link
Member

Awesome, thanks for this! Do you think it would be possible to test this in any meaningful way? If not, I'm fine with merging it like this.

@joarfish
Copy link
Author

I've tested it manually on Windows 10 and macos. Do you need proper unit testing?

@LPGhatguy LPGhatguy mentioned this pull request Jan 29, 2020
Closed
@conectado conectado mentioned this pull request Apr 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joarfish @happenslol