Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): upgrade to node v20 #359

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

work933k
Copy link

@work933k work933k commented Nov 4, 2024

Description

This PR proposes to update this package to use a more recent Node version (v20.*). This update required some additional fixes to get tests to succeed.

Motivation and Context

The use of an old Node version (v14.*) makes it hard to provide other improvements for this package.

How Has This Been Tested?

I ran the given test locally.
I also added node v20 as test to CI.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Jest-Image-Snapshot?

I don't expect developers/users to be negatively be impacted.

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024

CLA assistant check
All committers have signed the CLA.

@work933k work933k marked this pull request as ready for review November 4, 2024 10:52
@work933k work933k requested a review from a team as a code owner November 4, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants