Skip to content

Commit

Permalink
chore(dist): remove images from install bundle (#307)
Browse files Browse the repository at this point in the history
fixes #294
  • Loading branch information
10xLaCroixDrinker authored Aug 25, 2022
1 parent cd4fa73 commit 6cfa90a
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# node & npm
*.log

# github
.github

# test
test-results
__diff_output__
Expand All @@ -10,5 +13,8 @@ __tests__
# examples
examples

# doc assets
images

# IDE
.idea
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<h1 align="center">
<img src='https://github.com/americanexpress/jest-image-snapshot/raw/main/jest-image-snapshot.png' alt="Jest Image Snapshot - One Amex" width='50%'/>
<img src='https://github.com/americanexpress/jest-image-snapshot/raw/main/images/jest-image-snapshot.png' alt="Jest Image Snapshot - One Amex" width='50%'/>
</h1>

[![npm](https://img.shields.io/npm/v/jest-image-snapshot)](https://www.npmjs.com/package/jest-image-snapshot)
Expand Down Expand Up @@ -53,15 +53,15 @@ it('renders correctly', async () => {
...
```

<img title="Adding an image snapshot" src="./images/create-snapshot.gif" width="50%">
<img title="Adding an image snapshot" src="https://raw.githubusercontent.com/americanexpress/jest-image-snapshot/main/images/create-snapshot.gif" width="50%">

Then after a few days as I finish adding another feature to my component I notice one of my tests failing!

<img title="A failing image snapshot test" src="./images/fail-snapshot.gif" width="50%">
<img title="A failing image snapshot test" src="https://raw.githubusercontent.com/americanexpress/jest-image-snapshot/main/images/fail-snapshot.gif" width="50%">

Oh no! I must have introduced a regression! Let's see what the diff looks like to identify what I need to fix:

<img title="Image diff" src="./images/image-diff.png" width="50%">
<img title="Image diff" src="https://raw.githubusercontent.com/americanexpress/jest-image-snapshot/main/images/image-diff.png" width="50%">

And now that I know that I broke the card art I can fix it!

Expand Down
File renamed without changes

0 comments on commit 6cfa90a

Please sign in to comment.