support more operators in conditions #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
approved these changes
Dec 4, 2017
🙏 👍 |
dirk-thomas
added a commit
that referenced
this pull request
Dec 4, 2017
|
Doh 😞 I just re-ran the tests locally again and they still passed. After some digging it turns out that the new version of the flake8-import-order (0.16) seems to be more picky than the version I had locally (1.13). I committed the referenced fix to master. Thanks for pointing it out. |
|
it's happened to all of us I think (well, myself at least)! |
|
I guess that is why we don't recommend users to install stuff via pip - since it doesn't get updated regularly like apt... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the change from ros-infrastructure/rep#146.