Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ament_xmllint testing for all packages that we can. #508

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

clalancette
Copy link
Contributor

This is to catch invalid changes to the package.xml mostly. Note that there are a few packages in here which we cannot add this, since it would end up in a circular dependency between ament_xmllint and those packages.

This is part of getting to ros2/ros2cli#944 , in the sense that it fixes the core to actually do this. @sloretz FYI

This is to catch invalid changes to the package.xml mostly.
Note that there are a few packages in here which we cannot
add this, since it would end up in a circular dependency
between ament_xmllint and those packages.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Contributor Author

Pulls: #508
Gist: https://gist.githubusercontent.com/clalancette/218f908b3edab3aa90fc9fd25ab0cba7/raw/3142f13daa4b9cd4d836eb42629926ae22b23ad8/ros2.repos
BUILD args: --packages-above-and-dependencies ament_clang_format ament_clang_tidy ament_cppcheck ament_cpplint ament_lint_cmake ament_mypy ament_pclint ament_pycodestyle ament_pyflakes ament_uncrustify ament_xmllint
TEST args: --packages-above ament_clang_format ament_clang_tidy ament_cppcheck ament_cpplint ament_lint_cmake ament_mypy ament_pclint ament_pycodestyle ament_pyflakes ament_uncrustify ament_xmllint
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14773

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit f701809 into rolling Nov 2, 2024
3 checks passed
@clalancette clalancette deleted the clalancette/add-ament-xmllint branch November 2, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants