Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for non-hilt Applications #37

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

mrajatttt
Copy link
Contributor

@mrajatttt mrajatttt commented Oct 28, 2024

Issue Number:

Description:

What are the changes? Why are we making them?

  • Adding support for non-hilt applications, A customer pointed out that their application does not use hilt and our SDK was forcing them to include hilt/dagger dependencies.

Functional backward compatibility:

Does this change introduce backwards incompatible changes? [YES/NO]

NO

Does this change introduce any new dependency? [YES/NO]

NO


Testing:

Is the code unit tested?
YES
Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?
YES
List manual testing steps:

  • Add Steps below:

Here are a list of manual test cases to run through:

  • Initiating chat and connecting with an agent
  • Retrieving transcript
  • Disconnecting from chat
  • Sending a message to the agent
    • See typing bubbles on agent side
    • See read/delivered receipt on client side
    • Receiving a message from the agent
    • See typing bubbles on client side
    • See read/delivered receipt on agent side
    • Sending an attachment to the agent (try .txt, .pdf, .jpg)
    • Preview the attachment on click
    • Receiving an attachment from the agent
    • Preview the attachment on click
  • Close the application (Without ending chat) → open app again → Start chat → Should Retrieve transcript from a previous chat session

@mliao95
Copy link
Contributor

mliao95 commented Oct 28, 2024

Does this change introduce backwards incompatible changes? [YES/NO]

YES

What backwards incompatible changes are we introducing here? If anything aren't we generalizing support for projects with/without hilt dependency?

@mrajatttt
Copy link
Contributor Author

Does this change introduce backwards incompatible changes? [YES/NO]
YES

What backwards incompatible changes are we introducing here? If anything aren't we generalizing support for projects with/without hilt dependency?

My bad, I thought it was support backward changes!

@mrajatttt mrajatttt merged commit 1806b58 into main Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants