Implementing getAttachmentDownloadUrl #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mliao95
changed the title
agarwhi
reviewed
Oct 17, 2024
chat-sdk/src/main/java/com/amazon/connect/chat/sdk/network/AttachmentsManager.kt
Outdated
Show resolved
Hide resolved
agarwhi
reviewed
Oct 17, 2024
chat-sdk/src/main/java/com/amazon/connect/chat/sdk/repository/ChatService.kt
Outdated
Show resolved
Hide resolved
mrajatttt
approved these changes
Oct 17, 2024
| @@ -68,6 +70,7 @@ class AttachmentsManager @Inject constructor( | |||
| } | |||
|
|
|||
| suspend fun completeAttachmentUpload(connectionToken: String, attachmentId: String) { | |||
| print("HIT!!") | |||
agarwhi
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Description:
What are the changes? Why are we making them?
Implementing
getAttachmentDownloadUrl+ unit tests.getAttachmentDownloadUrlwill return the S3 download URL for an attachment in the case the user wants to handle the download logic themselves.Functional backward compatibility:
Does this change introduce backwards incompatible changes? [YES/NO]
NO
Does this change introduce any new dependency? [YES/NO]
NO
Testing:
Is the code unit tested?
YES
Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?
List manual testing steps:
Here are a list of manual test cases to run through: