Support for bengali language #674
Conversation
| /*___Generated_by_IDEA___*/ | ||
|
|
||
| package org.amahi.anywhere; | ||
|
|
||
| /* This stub is only used by the IDE. It is NOT the BuildConfig class actually packed into the APK */ | ||
| public final class BuildConfig { | ||
| public final static boolean DEBUG = Boolean.parseBoolean(null); | ||
| } |
There was a problem hiding this comment.
What's this file? Is it necessary?
There was a problem hiding this comment.
@chirag-jn I don't know about this file. when i created 1st pull request i get a error in github then a went to git bush and commit all files and then i created pull request and github did not show me any eror. I just edited string.xml files nothing more than that.
There was a problem hiding this comment.
No issues. Check if removing this file is sufficient and make another commit to the same branch.
| <string name="message_empty_recent_files">সাম্প্রতিক ফাইল অনুপস্থিত</string> | ||
| <string name="message_empty_shares">শেয়ার অনুপস্থিত</string> | ||
| <string name="message_error_account_exists">অ্যাকাউন্ট ইতিপূর্বে আছে।</string> | ||
| <string name="message_error_amahi_anywhere_app">The Amahi Anywhere অ্যাপটি আপনার সার্ভার এর কোন জায়গার আয়ত্তাধীন নয়।দয়া করে The Amahi Anywhere অ্যাপটি আপনার নেটওয়ার্কে ইনস্টল, চলমান আর আয়ত্তাধীন তা নিশ্চিত করুন।</string> |
There was a problem hiding this comment.
Please check the translation of this sentence if it's translated properly.
There was a problem hiding this comment.
@chirag-jn yes this sentense is translated properly. I didn't changed The Amahi Anywhere because I thought it is a brnad name and It should be stay as it is. Should I aslo translate "The Amahi Anywhere"?
There was a problem hiding this comment.
"The Amahi Anywhere" isn't a brand per se but "Amahi Anywhere" is
There was a problem hiding this comment.
Ok understand I will fix this @chirag-jn
| <string name="message_notice_create_some">কিছু তৈরি করে পুনরায় চেষ্টা করুন</string> | ||
| <string name="message_notice_visit_some">কিছু পরিদর্শন করে পুনরায় চেষ্টা করুন</string> | ||
| <string name="message_offline_file_deleted">অফ্লাইন ফাইল সফলভাবে সরানো হয়েছে</string> | ||
| <string name="message_progress_file_downloading">ফাইলটি ডাউনলোড হচ্ছে ...</string> |
There was a problem hiding this comment.
Please see these triple dots in other values files. Studio must give a warning for placing three dots like this.
There was a problem hiding this comment.
@chirag-jn No, Studio didn't give me any error and even in default language and other string values this three dots are like this.
There was a problem hiding this comment.
In other files, it's represented as one character, but here it's represented as three characters. Also it will be a warning and not an error. Try running linter on this file.
There was a problem hiding this comment.
Ok. I am tring I will inform you after sometime
| /*___Generated_by_IDEA___*/ | ||
|
|
||
| package org.amahi.anywhere; | ||
|
|
||
| /* This stub is only used by the IDE. It is NOT the Manifest class actually packed into the APK */ | ||
| public final class Manifest { | ||
| } |
There was a problem hiding this comment.
What's this file? Is it necessary?
| /*___Generated_by_IDEA___*/ | ||
|
|
||
| package org.amahi.anywhere; | ||
|
|
||
| /* This stub is only used by the IDE. It is NOT the R class actually packed into the APK */ | ||
| public final class R { | ||
| } |
There was a problem hiding this comment.
What's this file? Is it necessary?
There was a problem hiding this comment.
@chirag-jn I don't know about this file. when i created 1st pull request i get a error in github then a went to git bush and commit all files and then i created pull request and github did not show me any eror. I just edited string.xml files nothing more than that.
There was a problem hiding this comment.
Please check the files again. We don't need these files.
|
Adding language file isn't enough. You have to add support for switching the language too! Check |
chirag-jn
added
on hold
|
This PR is a step towards #548 |
chirag-jn
changed the title
Bengali{bn) new language added.
@chirag-jn As you said I add a new language Please review it.