Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotel, anchored search and a lot of others calls and tags #336

Open
wants to merge 102 commits into
base: master
Choose a base branch
from

Conversation

gabrieleleo
Copy link
Contributor

our developers have develop a lot of new stuff for your library, unfortunately they have commit everythings in master and without test unit in module. we don't have time to do that kind of stuff for this module, but our version run without any problem at all and have hotel.

can anyone help?

DerMika and others added 30 commits December 16, 2016 12:23
Conflicts:
	src/Amadeus/Client.php
	src/Amadeus/Client/RequestOptions/FareMasterPricerTbSearch.php
	src/Amadeus/Client/Struct/Fare/MasterPricer/FareOptions.php
	src/Amadeus/Client/Struct/Fare/MasterPricerTravelBoardSearch.php
	tests/Amadeus/Client/Struct/Fare/MasterPricerTravelBoardSearchTest.php
- Service_StandaloneCatalogue Message is added
New Message Service_StandaloneCatalogue implementation
ServiceStandaloneCatalogue Changes
@therealartz
Copy link
Collaborator

therealartz commented Jun 11, 2019

It's very good that there are a lot of working functionality, but it's need a huge refactor for such library and also unit tests anyway.

I'll see how I can help here...

@gabrieleleo
Copy link
Contributor Author

It's very good that there are a lot of working functionality, but it's need a huge refactor for such library and also unit tests anyway.

I'll see what I can help here...

would be great. our developers really love this library but they don't use unit test for it, we've start to implement a lot of things, also train in future.

@DerMika
Copy link
Collaborator

DerMika commented Jun 23, 2019

It's great to have so many features, but you'll have to split them up. I can't review one giant blob of files properly, plus, it's got merge conflicts.

If you were to start for example by extracting all Hotel message changes into a separate pull request, and work from there, we can get somewhere. But these are too many changes for a single pull request.

m0veax pushed a commit to proappers/amadeus-ws-client that referenced this pull request Feb 2, 2020
…Repository

refactored code, removed duplicates and removed IDE specific comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants