Skip to content

Commit

Permalink
feature/expand-response-storage (#15)
Browse files Browse the repository at this point in the history
* Added unique message when internal rate limit vs external rate limit; Added storing of response and code

* Added observer to ensure body is json not string
  • Loading branch information
Quentin Schmick authored Aug 1, 2022
1 parent 8c29a1f commit bbcf79b
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 3 deletions.
6 changes: 4 additions & 2 deletions src/Message/RateLimitExceededException.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,16 @@ final class RateLimitExceededException extends ShipEngineException
* @param DateInterval $retryAfter
* @param string|null $source
* @param string|null $requestId
* @param string $message
*/
public function __construct(
DateInterval $retryAfter,
string|null $source = null,
string|null $requestId = null
string|null $requestId = null,
string $message = 'You have exceeded the rate limit.',
) {
parent::__construct(
'You have exceeded the rate limit.',
$message,
$requestId,
$source,
'System',
Expand Down
7 changes: 7 additions & 0 deletions src/Models/RequestLog.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace BluefynInternational\ShipEngine\Models;

use AlwaysOpen\RequestLogger\Models\RequestLogBaseModel;
use BluefynInternational\ShipEngine\Observers\RequestLogObserver;

/**
* BluefynInternational\ShipEngine\Models\RequestLog
Expand All @@ -18,6 +19,12 @@
*/
class RequestLog extends RequestLogBaseModel
{
protected static function boot()
{
parent::boot();
parent::observe(RequestLogObserver::class);
}

public function getTable()
{
return config('shipengine.request_log_table_name');
Expand Down
19 changes: 19 additions & 0 deletions src/Observers/RequestLogObserver.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php

namespace BluefynInternational\ShipEngine\Observers;

use AlwaysOpen\RequestLogger\Models\RequestLogBaseModel;

class RequestLogObserver
{
public function saving(RequestLogBaseModel $model)
{
if (is_string($model->body)) {
try {
$model->body = json_decode($model->body, true);
} catch (\Exception $e) {
// no op
}
}
}
}
5 changes: 4 additions & 1 deletion src/ShipEngineClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ private static function sendRequest(
}

try {
$response = null;
self::incrementRequestCount($config);

$response = $client->send(
Expand All @@ -200,6 +201,8 @@ private static function sendRequest(
}
} catch (Exception|Throwable $err) {
if (config('shipengine.track_requests')) {
$requestLog->response_code = $response?->getStatusCode();
$requestLog->response = $requestLogResponse ?? null;
$requestLog->exception = substr($err->getMessage(), 0, config('shipengine.request_log_table_exception_length'));
$requestLog->save();
}
Expand Down Expand Up @@ -294,7 +297,7 @@ private static function incrementRequestCount(ShipEngineConfig $config) : void
$nextExpire = now()->seconds(0)->addMinute();

if ($count > $config->requestLimitPerMinute) {
throw new RateLimitExceededException(retryAfter: new DateInterval('PT1S'));
throw new RateLimitExceededException(retryAfter: new DateInterval('PT1S'), message: 'Internal conifg API rate limit exceeded.');
}

Cache::put('shipengine.api-request.count', $count + 1, $nextExpire);
Expand Down

0 comments on commit bbcf79b

Please sign in to comment.