Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all base16 themes #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add all base16 themes #26

wants to merge 4 commits into from

Conversation

aloisdg
Copy link

@aloisdg aloisdg commented Jan 8, 2016

Hello,

I opened #25 to talk about this PR.

Cheers,

@acrisci
Copy link
Member

acrisci commented Jan 10, 2016

I just checked out the project you used to generate those and it looks pretty cool.

Unfortunately, there is not enough room for all these themes to be distributed with the utility so I have to enforce some quality control now.

So far, I have accepted all the themes people send me because I figure that if one person took the time to create it and submit it, then other people will probably like it to.

So I will continue with this as my quality control standard. If you have one or two that you particularly like to use, I will accept them into the project to be distributed under the themes directory.

The other themes I will accept into the project under a new directory under base16-themes. Please include a description in the README under that directory that describes how they were generated as well as a script that is used to generate them (in case we ever need to generate them again).

@aloisdg
Copy link
Author

aloisdg commented Jan 10, 2016

I am using Railscast right now but I might change to Atelier Heath or Eighties. I think I will push everything to a subfolder called base16. Should I move tomorrow too? I think so, but you can choose. Should I use a README.md or the wiki? (I will start with a README.md).

@oryband
Copy link

oryband commented Feb 1, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants