Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code hiding groups controller behind feature flag #1595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lfdebrux
Copy link
Member

What problem does this pull request solve?

We don't ever want to switch off the groups feature flag, so we don't need this code.

Unfortunately I don't have time to remove all the related code, but we can at least chip away at it slowly.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

We don't ever want to switch off the groups feature flag, so we don't
need this code.

Unfortunately I don't have time to remove all the related code, but we
can at least chip away at it slowly.
Copy link

sonarcloud bot commented Nov 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant