resource/alicloud_ess_scaling_group: Fixed weighted_capacity and spot_price_limit is null. #7418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuliu-zln
changed the title
fuliu-zln
force-pushed
the
fix/group
branch
2 times, most recently
from
507ccb8
to
9e084b4
Compare
ChenHanZhang
reviewed
Jul 3, 2024
| @@ -352,12 +352,16 @@ func resourceAliyunEssScalingGroupRead(d *schema.ResourceData, meta interface{}) | |||
| result := make([]map[string]interface{}, 0) | |||
| for _, i := range v.(map[string]interface{})["LaunchTemplateOverride"].([]interface{}) { | |||
| r := i.(map[string]interface{}) | |||
| f, _ := r["SpotPriceLimit"].(json.Number).Float64() | |||
There was a problem hiding this comment.
这些变量用可以读得懂的方式命名吧，这种以后其他人很难维护
fuliu-zln
force-pushed
the
fix/group
branch
4 times, most recently
from
d20275e
to
3513db9
Compare
…_price_limit is null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rice_limit is null.