Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add imds and external uri in default chain && refactor credenti… #660

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

yndu13
Copy link
Contributor

@yndu13 yndu13 commented Nov 11, 2024

…als provider

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 91.73554% with 50 lines in your changes missing coverage. Please review.

Project coverage is 94.08%. Comparing base (1a7bea3) to head (e1d2392).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
sdk/auth/credentials/credentials.go 93.63% 14 Missing and 10 partials ⚠️
...k/auth/credentials/profile_credentials_provider.go 72.97% 7 Missing and 3 partials ⚠️
...k/auth/credentials/default_credentials_provider.go 78.78% 4 Missing and 3 partials ⚠️
sdk/auth/credentials/uri_credentials_provider.go 94.23% 4 Missing and 2 partials ⚠️
...th/credentials/cli_profile_credentials_provider.go 94.44% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   94.57%   94.08%   -0.49%     
==========================================
  Files          56       57       +1     
  Lines        3961     4529     +568     
==========================================
+ Hits         3746     4261     +515     
- Misses        157      192      +35     
- Partials       58       76      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yndu13 yndu13 merged commit d12d548 into master Nov 11, 2024
9 checks passed
@yndu13 yndu13 deleted the imdsv2 branch November 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants