-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump flatbuffers and use internal flatbuffers in ONNXRuntime #5413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we simply move flatbuffers to a version which everyone likes? I would prefer not having two versions.
ONNXRuntime does not support any newer version, and will not in the foreseeable future as they say they can anyway do this internal build.
|
Fair enough, but why bumping it, then? Is it required to get the new GCC working? If yes, how come the internal version does work? |
That is a good question, I was wondering the same. For me our flatbuffers did not compile with gcc13, while the 9nnx-internal version compiled. I didn't check if they somehow fixed it. Anyhow, I don't like using a many years old version due to onnx decising they do not want to bump...
|
@davidrohr do you understand the issue on cs8? |
@ktf : which issue on cs8? |
yesterday it was failing. maybe it was simply a glitch in the wrong package. |
Now Ubuntu fails, but it was green before. So I think it is more random ctests failing. |
Yes, indeed ubuntu is unrelated. |
no longer needed with onnx bumped to 1.18 |
No description provided.