Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add implementation and configuration classes for OpenSearch vector storage #240

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fuyou-lxm
Copy link

@fuyou-lxm fuyou-lxm commented Dec 19, 2024

Describe what this PR does / why we need it
Add implementation and configuration classes for OpenSearch vector storage
Does this pull request fix one issue?
yes,#230
Describe how you did it

  • Added OpenSearchVector.java file, which implements the VectorStore interface for interacting with Alibaba OpenSearch. This class supports functionalities such as adding, deleting, and similarity searching of vector documents.
  • Added OpenSearchConfig.java file, which defines the parameters required to connect and configure OpenSearch, including instance ID, endpoint, username, and password.

Describe how to verify it

Special notes for reviews

- 新增 `OpenSearchVector.java` 文件,实现了 `VectorStore` 接口,用于与 Alibaba OpenSearch 进行交互。该类支持向量文档的添加、删除和相似度搜索功能。
- 新增 `OpenSearchConfig.java` 文件,定义了连接和配置 OpenSearch 所需的参数,包括实例 ID、endpoint、用户名和密码等配置项。

这些改动为项目引入了对 Alibaba OpenSearch 的支持,增强了系统的向量存储能力。
@fuyou-lxm fuyou-lxm changed the title feat: 添加 OpenSearch 向量存储实现及配置类 feat: Add implementation and configuration classes for OpenSearch vector storage Dec 19, 2024
this.accessUserName = accessUserName;
}

public String getAccessPassWord() { // 新增
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释用英语吧

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除中文注释,再Review下

/**
* Represents the response body from a search operation.
*
* @author fuyou.lxm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

方法上可以去掉,在类上加上作者注释

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是record类型,实际是static class,并不是方法

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants