feat: support host monitor #1890
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abingcbc
force-pushed
the
host_monitor
branch
6 times, most recently
from
6150e52 to
bfdd9c2
Compare
messixukejia
requested changes
Nov 25, 2024
henryzhx8
requested changes
Nov 26, 2024
Abingcbc
force-pushed
the
host_monitor
branch
from
4110e3d to
3e12438
Compare
messixukejia
requested changes
Nov 30, 2024
| targetEvent->SetContent("binary", sourceEvent.GetContent(DEFAULT_CONTENT_KEY_PROCESS_BINARY)); | ||
| targetEvent->SetContent("arguments", sourceEvent.GetContent(DEFAULT_CONTENT_KEY_PROCESS_ARGUMENTS)); | ||
| targetEvent->SetContent("language", sourceEvent.GetContent(DEFAULT_CONTENT_KEY_PROCESS_LANGUAGE)); | ||
| targetEvent->SetContent("containerID", sourceEvent.GetContent(DEFAULT_CONTENT_KEY_PROCESS_CONTAINER_ID)); |
There was a problem hiding this comment.
需要统一到constans里字段。需要避免同一场景一会下划线，一会大小写的问题。
| class ProcessCollector : public BaseCollector { | ||
| public: | ||
| ProcessCollector() : mProcessSilentCount(INT32_FLAG(process_collect_silent_count)) { | ||
| mName = "process"; |
|
|
||
| namespace logtail { | ||
|
|
||
| const std::string ProcessorHostMetaNative::sName = "processor_host_meta_native"; |
There was a problem hiding this comment.
inner processor存在的必要性是什么？为什么不能collect时直接补充字段
| const auto now = steady_clock::now(); | ||
|
|
||
| // TODO: more accurate cache | ||
| auto prev = GetPreProcessStat(pid); |
There was a problem hiding this comment.
mPrevProcessStat 使用场景很局部，都是内部使用，保持统一。
|
|
||
| int readCount = 0; | ||
| WalkAllProcess(PROCESS_DIR, [&](const std::string& dirName) { | ||
| if (++readCount > mProcessSilentCount) { |
There was a problem hiding this comment.
个数控制是不是也在控制缓存里的？不应该只是控制去直接操作系统交互的吗
messixukejia
requested changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO：