feat: lettuce factory support pub/sub connection #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areyouok
reviewed
Oct 28, 2024
| @@ -47,11 +49,13 @@ private LettuceObjects getLettuceObjectsFromMap(AbstractRedisClient redisClient) | |||
| } | |||
|
|
|||
| public void init(AbstractRedisClient redisClient, StatefulConnection connection) { | |||
There was a problem hiding this comment.
init方法有一个就行了，用两个参数就可以。如果不想破坏兼容性，可以加一个双参数的，然后把原来的标记为废弃。这里把connection的赋值放在外面，有理论上的线程安全问题吧？
|
我刚注意到这个pr，不知道什么时候完成的？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #707
My application similar to this issue, uses
LettuceFactoryto get the Connection globally.