feat: add try-paths plugins #1598
Open
+444
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haifzhu
requested review from
Xunzhuo,
2456868764,
CH3CHO,
johnlanni and
WeixinX
as code owners
johnlanni
requested changes
Dec 18, 2024
|
|
||
| | 名称 | 数据类型 | 填写要求 | 默认值 | 描述 | | ||
| | -------- | -------- | -------- | -------- | -------- | | ||
| | serviceSource | string | 必填 | - | 支持k8s,nacos,ip,dns | |
There was a problem hiding this comment.
只支持FQDN格式的serviceName就可以了，这样能简化下配置，不需要配serviceSource
| } | ||
|
|
||
| log.Debugf("try path start, path: %s", config.tryPaths[index]) | ||
| requestPath := strings.Replace(config.tryPaths[index], VariableReplacedStr, path, -1) |
There was a problem hiding this comment.
tryPath 里面存在 $uri 这样的变量，应该需要解析出来吧？
There was a problem hiding this comment.
tryPath 里面存在 $uri 这样的变量，应该需要解析出来吧？
是在上面debug的输出里面需要打印出请求路径对吧？不要tryPaths中的原路径。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
==========================================
+ Coverage 35.91% 43.47% +7.56%
==========================================
Files 69 76 +7
Lines 11576 12325 +749
==========================================
+ Hits 4157 5358 +1201
+ Misses 7104 6631 -473
- Partials 315 336 +21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add try-paths wasm go plugin to implement try_files function of nginx。
Ⅱ. Does this pull request fix one issue?
Fix the issue: Add support of try_files usage #840 .
Ⅲ. Why don't you add test cases (unit test/integration test)?
test cases be added in codes.
Ⅳ. Describe how to verify it
enable the plugin on the route, and check its retry function on envoy log or request response.
Ⅴ. Special notes for reviews
no