feat: add TLS version annotation support for per-rule configuration #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunmaoQu
requested review from
SpecialYang,
johnlanni and
CH3CHO
as code owners
|
qu ym seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
johnlanni
requested changes
Dec 16, 2024
| @@ -138,6 +138,10 @@ type AnnotationHandler interface { | |||
| RouteHandler | |||
| TrafficPolicyHandler | |||
There was a problem hiding this comment.
It is suggested to extend this implementation, rather than creating a separate file.
https://github.com/alibaba/higress/blob/main/pkg/ingress/kube/annotations/downstreamtls.go
There was a problem hiding this comment.
ok,get it,i will get it a try ,thanks for your review.
There was a problem hiding this comment.
Thank you for contributing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support for setting TLS version annotations (
tls-min-versionandtls-max-version) for per-rule configurations in Higress. This allows users to override global TLS settings for specific ingress rules.Ⅱ. Does this pull request fix one issue?
fix #1586
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Verified functionality with unit tests (
TestTLSConfig) and integration tests.Manually tested with custom ingress rules.
Ⅴ. Special notes for reviews